Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type attributes to LLVM C API #15

Merged

Conversation

seanyoung
Copy link

@seanyoung seanyoung commented Aug 23, 2021

This commit from llvm 12.0.1 is needed to make the solang llvm 12 build work on windows.

The LLVM C API is missing type attributes as is needed by attributes
such as sret and byval. This patch adds three missing wrapper
functions.

Bugzilla: https://bugs.llvm.org/show_bug.cgi?id=48249

https://reviews.llvm.org/D97763
(cherry picked from commit 528f6f7)
@seanyoung
Copy link
Author

@dmakarov would you able to merge this. This fixes this issue I have of building solang with llvm 12 on Windows: https://github.com/hyperledger-labs/solang/runs/3402273809?check_suite_focus=true

It's cherry-picked of the release/12.x branch

Thanks

@dmakarov dmakarov merged commit 105deee into anza-xyz:solana-rustc/12.0-2021-04-15 Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants